alxs wrote:I am reading the source code now... No offence, guys, but it's a mess.
Yes, I know. What you have to take into consideration is that this is the first major project that either of us has undertaken and we all have different ways of doing things, essentially we were never thinking that our programming code was going to be graded (aka: someone was going to look at it.. ever). LÖVE has gotten way more attention than we thought it would get.
alxs wrote:You have lots of external libraries, evreything is unsorted and you suffer from the typical desease of beginners - creating way too many classes.
In programming - the less is more. Simplicity is the key
Oh, you should have seen it before the last major cleanup... it was an unholy mess.
alxs wrote:I have some questions:
Alright... what do you want now?? </fake anger>
alxs wrote:1. It seems that love.graphics:setFont() changes ALL the drawn fonts somehow. Weird. If I use this code:
love.graphics:draw("test", 70, 250, 200, love.align_left)
love.graphics:setFont(rpgfont)
love.graphics:draw("test2", 310, 250, 200, love.align_center)
The font will be set the same for both strings! What’s the logic behind this strange behavior?
That is because the draw() function is called consecutively and the font isn't reset at the beginning of the function.
Code: Select all
love.graphics:setFont(oldfont) -- this is necessary
love.graphics:draw("test", 70, 250, 200, love.align_left)
love.graphics:setFont(rpgfont)
love.graphics:draw("test2", 310, 250, 200, love.align_center)
alxs wrote:2. What’s “FontTexGame”?
Seems like somebody is snooping.
FontTexGame is an internal test game, so that we can make/test/fix functions before exposing them to Lua.
alxs wrote:3. I see that you use certain format for comments – is it for some automated documentation tool?
I believe that was the idea, yes, but I haven't seen it come to pass yet.
alxs wrote:4. Are you using OpenGL to render 2D graphics in 3D?
Eh.. yes? Not sure what you are asking. Wait for rude to come.. he knows.
alxs wrote:5. Why the heck do you need a special library to provide access to the FileSystem??? Isn't C funtions enough?
I believe that this was done so that we could read from zip files as well as folders.
alxs wrote:6. What's "balance"? Is it resource management by counting references?
Wait for rude.
alxs wrote:7. Is there full source code available with all the libaries and VS projects?
Rude.
alxs wrote:8. What's with all the "printf's" in graphic mode???
Are you asking why we are using printf to output errors and such? Is there any better way until we have developed an internal gui for displaying messages?
alxs wrote:That's all for now
For now? Jesus...
Hehe, that's alright. You're keeping us on our toes.. which is good.
About your second post: I am completely dumb when it comes to graphics and SWIG stuff so once again: rude will answer you.